Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] Ability to define GPG key path for Docker APT #10513

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[docker] Ability to define GPG key path for Docker APT #10513

merged 1 commit into from
Oct 13, 2023

Conversation

emiran-orange
Copy link
Contributor

@emiran-orange emiran-orange commented Oct 11, 2023 •
edited by floryut
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Enables setting a path for GPG key for Docker repo on Debian systems to avoid the well-known warning (Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details)

Which issue(s) this PR fixes:
NONE

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

[docker] Ability to define GPG key path for Docker APT (using new variable `docker_repo_key_keyring`)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @emiran-orange. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2023
@yankay
Copy link
Member

yankay commented Oct 12, 2023

Thanks @emiran-orange

Would you please slash the commits.

/ok-to-test

👍👍

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2023
@emiran-orange
Copy link
Contributor Author

Would you please slash the commits.

@yankay I think it's done now

@emiran-orange
Copy link
Contributor Author

@yankay It just came to mind that some test cases (Debian 12 and/or Ubuntu 22.04) may be updated to use the variable... WDYT ?

@yankay
Copy link
Member

yankay commented Oct 12, 2023

@yankay It just came to mind that some test cases (Debian 12 and/or Ubuntu 22.04) may be updated to use the variable... WDYT ?

Thanks, It's good idea for me :-)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@emiran-orange
Copy link
Contributor Author

@yankay Just added the var in packet_debian12-docker.yml and packet_ubuntu22-aio-docker.yml, does it still lgty ?

@floryut floryut added kind/container-managers Containers section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Oct 12, 2023
floryut
floryut approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emiran-orange Thank you for the PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emiran-orange, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@yankay
Copy link
Member

yankay commented Oct 13, 2023

Thanks @emiran-orange

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit e65050d into kubernetes-sigs:master Oct 13, 2023
59 checks passed
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
@emiran-orange
Ability to define GPG key path for Docker APT (kubernetes-sigs#10513)
0d4e413
@yankay yankay mentioned this pull request Dec 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@emiran-orange @pedromcpedro
Ability to define GPG key path for Docker APT (kubernetes-sigs#10513)
db35bbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@oomichi oomichi Awaiting requested review from oomichi

@yankay yankay Awaiting requested review from yankay

Assignees

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emiran-orange @k8s-ci-robot @yankay @floryut